-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed regex deprecation warning #390
Conversation
I created a new branch and made changes.But the previously made changes(in other branches) are also added in this branch.Hence this PR contains files changed in previous branch also.But no other repositories had this problem.Any solution for this. |
Also it is showing test_scanner has conflicts.What to do? |
Test_scanner conflicts fixed. |
I don't know why the test is failing.Cn you help @terriko |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with #376, please make a fresh branch for this and make sure it's done off the latest master. It's too hard to do code review with all these extra changes showing. I don't think the failing tests are related -- @PrajwalM2212 indicated elsewhere that kernel.org stopped serving a few of the files we were using.
Normally I take whichever patch comes first when people have very technically similar solutions, but since git is all messed up on this one and you're going to have a bunch of work to do on #376 already, I'm going to go ahead and take the next working patch in the PR list and close this one. |
#382