Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed regex deprecation warning #390

Closed
wants to merge 14 commits into from
Closed

Fixed regex deprecation warning #390

wants to merge 14 commits into from

Conversation

ananthan-123
Copy link
Contributor

@ananthan-123
Copy link
Contributor Author

I created a new branch and made changes.But the previously made changes(in other branches) are also added in this branch.Hence this PR contains files changed in previous branch also.But no other repositories had this problem.Any solution for this.

@ananthan-123
Copy link
Contributor Author

Also it is showing test_scanner has conflicts.What to do?

@ananthan-123 ananthan-123 mentioned this pull request Feb 22, 2020
@ananthan-123
Copy link
Contributor Author

Test_scanner conflicts fixed.

@ananthan-123
Copy link
Contributor Author

I don't know why the test is failing.Cn you help @terriko

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with #376, please make a fresh branch for this and make sure it's done off the latest master. It's too hard to do code review with all these extra changes showing. I don't think the failing tests are related -- @PrajwalM2212 indicated elsewhere that kernel.org stopped serving a few of the files we were using.

@terriko
Copy link
Contributor

terriko commented Feb 25, 2020

Normally I take whichever patch comes first when people have very technically similar solutions, but since git is all messed up on this one and you're going to have a bunch of work to do on #376 already, I'm going to go ahead and take the next working patch in the PR list and close this one.

@terriko terriko closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants