-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing long tests #378
Conversation
@terriko I opened this PR before seeing that there was a issue for this. I see that the issue is marked as |
If you want to re-open this for the nice little cleanup in setup.py, the other PR didn't cover that. |
The long tests were failing for all url's that begin with |
I have replaced the failing tests with new ones. |
Ugh, kernel.org, you're supposed to be stable and reliable. I blame the new management ;) |
Okay, I would have liked to keep exactly the same packages in a few places just for continuity, but I think these provide sufficiently equivalent coverage so I'm going to merge them. Of course we're screwed if rpmfind.net goes down again, but... that was always a possibility in the long tests. |
.github/workflows/pythonapp.yml
Outdated
@@ -57,7 +57,7 @@ jobs: | |||
run: | | |||
python -m pip install --upgrade pip | |||
pip install -r requirements.txt | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a silly change! I'm going to see if I can remove it before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to just take the blank lines out, so now you have a different silly change. Oh well, end result is a cleaner file so I'll take it! (assuming github actions is working again...)
No description provided.