Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing long tests #378

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Fix failing long tests #378

merged 4 commits into from
Feb 24, 2020

Conversation

PrajwalM2212
Copy link
Contributor

No description provided.

@PrajwalM2212
Copy link
Contributor Author

@terriko I opened this PR before seeing that there was a issue for this. I see that the issue is marked as good first issue. So I am closing this in case someone without a PR yet wants to try it.

@terriko
Copy link
Contributor

terriko commented Feb 21, 2020

If you want to re-open this for the nice little cleanup in setup.py, the other PR didn't cover that.

@PrajwalM2212 PrajwalM2212 reopened this Feb 22, 2020
@PrajwalM2212 PrajwalM2212 reopened this Feb 24, 2020
@PrajwalM2212 PrajwalM2212 changed the title Add pytest to requirements.txt Fix failing long tests Feb 24, 2020
@PrajwalM2212
Copy link
Contributor Author

The long tests were failing for all url's that begin with http://mirrors.kernel.org/fedora/releases/29/Workstation/x86_64/os/Packages/l/ . The link has become invalid.

@PrajwalM2212
Copy link
Contributor Author

I have replaced the failing tests with new ones.

@terriko
Copy link
Contributor

terriko commented Feb 24, 2020

Ugh, kernel.org, you're supposed to be stable and reliable. I blame the new management ;)

@terriko
Copy link
Contributor

terriko commented Feb 24, 2020

Okay, I would have liked to keep exactly the same packages in a few places just for continuity, but I think these provide sufficiently equivalent coverage so I'm going to merge them. Of course we're screwed if rpmfind.net goes down again, but... that was always a possibility in the long tests.

@@ -57,7 +57,7 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a silly change! I'm going to see if I can remove it before merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to just take the blank lines out, so now you have a different silly change. Oh well, end result is a cleaner file so I'll take it! (assuming github actions is working again...)

@terriko terriko merged commit fc414d9 into intel:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants