fix: non-alphanumeric characters as separators #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniogi
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Not a problem with the code itself, but I'm wondering if you need new tests to check that this always does what you want it to do. To be honest, I can't currently think of a case where you could have problems with converting all non-alpha to '.', but, at the same time, something is not feeling right there :| That's why I mention the extra tests.
This switches the logic so we treat all non-alphanumeric characters as separators equivalent to `.` in version strings. This should make the code more robust to unusual version strings. * Fixes intel#3558 (in that we will be able to handle `~`) Signed-off-by: Terri Oda <terri@toybox.ca>
terriko
force-pushed
the
special_chars
branch
from
a14a60b
to
ed0a3c6
Compare
antoniogi
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the logic so we treat all non-alphanumeric characters as separators equivalent to
.in version strings. This should make the code more robust to unusual version strings.~)