-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing docstrings to data_sources/gad_source.py #3466 #3488
Conversation
@terriko Sorry for the inconvenience! The previous PR was creating a lot of conflicts so I created a new PR with new commit. please look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed request change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the black linter is failing. if you run black
it should fix the file for you, then you'll need to add the fixed file to the PR.
how can I fix it? |
As I said, you'll need to run black on the file to fix it. I'll write it out for you: If you don't have black installed, start with pip install black Then run it on the file black data_sources/gad_source.py It will automatically change the file for you, so don't forget to check the file back in and push it to your pr: git add data_sources/gad_source.py
git commit
git push |
And if you want to read up on linters, there's more about what they are and how we use them in https://github.com/intel/cve-bin-tool/blob/main/CONTRIBUTING.md#running-linters (I highly recommend pre-commit to help you in the future!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't merge this because it's still failing the black checks, but it's close enough to ready that I'll mark it as hacktoberfest approved so you can get the credit (I'm heading to bed soon so I won't be around for just-under-the-wire finishes!)
I've run black locally and made the changes it recommended (an extra blank line) so the tests will re-run now. |
Codecov Report
@@ Coverage Diff @@
## main #3488 +/- ##
==========================================
+ Coverage 77.94% 78.77% +0.82%
==========================================
Files 758 758
Lines 11483 11484 +1
Branches 1341 1342 +1
==========================================
+ Hits 8950 9046 +96
+ Misses 2110 2029 -81
+ Partials 423 409 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passing, time to merge. Thank you and happy hacktoberfest!
…intel#3488) fixes intel#3466 Co-authored-by: Terri Oda <terri@toybox.ca>
Updated the docstrings of two missing Functions
GAD_Source (L25).
GAD_Source.parse_multiple_version (L176)
Issue No - #3466