fix: do not hardcode console width #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 66e1df3, console width is hardcoded to 120 and so width auto-detection is disabled. Drop this line as most modern screens can display more than 120 characters and a lot of lines are truncated now that EPSS data, latest version, etc. are displayed. Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
force-pushed
the
do-not-hardcode-console-width
branch
from
855f934
to
7e5bdf4
Compare
Codecov Report
@@ Coverage Diff @@
## main #3451 +/- ##
==========================================
- Coverage 80.49% 74.81% -5.69%
==========================================
Files 758 758
Lines 11616 11616
Branches 1571 1571
==========================================
- Hits 9350 8690 -660
- Misses 1842 2583 +741
+ Partials 424 343 -81
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 66e1df3, console width is hardcoded to 120 and so width auto-detection is disabled. Drop this line as most modern screens can display more than 120 characters and a lot of lines are truncated now that EPSS data, latest version, etc. are displayed.