Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docstring with formatted with black. requesting new PR for version_scanner.py #3429

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

rabroldan
Copy link
Contributor

Still in progress updating docstring with proper string literals

Name Status
version_scanner.py
InvalidFileError (L32) COVERED
VersionScanner (L36) COVERED
VersionScanner.load_checkers (L78) COVERED
VersionScanner.available_checkers (L89) COVERED
VersionScanner.remove_skiplist (L96) COVERED
VersionScanner.print_checkers (L107) COVERED
VersionScanner.number_of_checkers (L110) COVERED
VersionScanner.available_language_checkers (L117) COVERED
VersionScanner.print_language_checkers (L130) COVERED
VersionScanner.number_of_language_checkers (L133) COVERED
VersionScanner.is_executable (L136) COVERED
VersionScanner.is_linux_kernel (L174) COVERED
VersionScanner.scan_file (L196) COVERED
VersionScanner.run_checkers (L234) COVERED
VersionScanner.clean_file_path (L272) COVERED
VersionScanner.scan_and_or_extract_file (L284) COVERED
VersionScanner.recursive_scan (L303) COVERED

@rabroldan
Copy link
Contributor Author

I closed the old PR ajust to see if this one would possible be better. I corrected the files and formatted it with black

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started the tests, but it looks like this doesn't actually have your docstrings in it. Not sure what happened but you might need to re-add them (they're still visible in your old PR if you accidentally deleted them on disk)

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #3429 (91058fd) into main (fb39948) will decrease coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3429      +/-   ##
==========================================
- Coverage   80.49%   79.90%   -0.59%     
==========================================
  Files         758      758              
  Lines       11616    11616              
  Branches     1571     1571              
==========================================
- Hits         9350     9282      -68     
- Misses       1842     1911      +69     
+ Partials      424      423       -1     
Flag Coverage Δ
longtests 74.79% <ø> (-5.70%) ⬇️
win-longtests 77.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cve_bin_tool/version_scanner.py 85.31% <ø> (+2.25%) ⬆️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're good to go, thank you! I'll fix the gitlint issue during merge. Thanks for working on this and happy hacktoberfest!

@terriko terriko merged commit e45767a into intel:main Oct 19, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants