-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add missing docstrings fetch_json_db.py #3381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, you've got some linter errors such as...
cve_bin_tool/fetch_json_db.py:44:6: E999 IndentationError: expected an indented block after function definition on line 35
I think mostly you need your strings indented one more level so they're in line with the code below the function definition. I put one in as an example but you can probably do the rest faster than I can through the web interface.
cve_bin_tool/fetch_json_db.py
Outdated
""" | ||
Initialize the Fetch_JSON_DB instance. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | |
Initialize the Fetch_JSON_DB instance. | |
""" | |
""" | |
Initialize the Fetch_JSON_DB instance. | |
""" |
But the contents of the docstrings look good once we get the syntax fixed! |
My bad. Thank you for pointing out the exact fix. Fixed it. |
705c8ad
to
b72e565
Compare
Codecov Report
@@ Coverage Diff @@
## main #3381 +/- ##
==========================================
+ Coverage 80.72% 80.93% +0.20%
==========================================
Files 750 750
Lines 11534 11534
Branches 1560 1560
==========================================
+ Hits 9311 9335 +24
+ Misses 1786 1766 -20
+ Partials 437 433 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is ready to merge. Thank you @Niloth-p and congrats on your first commit with us. Happy hacktoberfest!
fixes #3380