-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unused and broken tests. #323
Conversation
test/test_json.py
Outdated
@@ -18,28 +19,35 @@ | |||
from urllib.request import urlopen | |||
|
|||
NVD_SCHEMA = "https://scap.nist.gov/schema/nvd/feed/1.1/nvd_cve_feed_json_1.1.schema" | |||
NVD_2019_META = "https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-2019.meta" | |||
NVD_2019_META = "https://nvd.nist.gov/feeds/json/cve/1.1/nvdcve-1.1-2020.meta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably change this to NVD_META
or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, we're not even using this any more; I might as well remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than NVD_2019_META
variable name this looks good.
Removed the no longer needed NVD_2019_META (since I removed teh meta function entirely -- it's been replaced by inline sha checks) |
I've removed the meta checker, since it's now being done inline. I can't decide if we want to do the jsonschema test inline (it's kind of slow) so I've updated the test suite test instead.