-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Include EPSS in JSON and CSV output #3211
Conversation
I tweaked the PR title to make a slightly more clear commit message: I know it's obvious to you that this is EPSS related but the original message sounded like "I've added a feature that is JSON and CSV output" rather than "I've modified our existing CSV and JSON output to include EPSS" I'm also going to re-run the failing tests. I think the failures are related to JSON issues on NVD's end and not something you changed, but I need the tests passing either way. |
@terriko I think the same test failing here but are passing on my own local and also on my fork. And for then name of PR I apologize. Next time I will keep that in mind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one's got tests! But I'd still like docs and we might need to consider error handling if metrics aren't populated. (maybe the if key != "metric":
is enough here, though)
Codecov Report
@@ Coverage Diff @@
## main #3211 +/- ##
==========================================
- Coverage 81.01% 80.94% -0.08%
==========================================
Files 716 716
Lines 11163 11170 +7
Branches 1497 1500 +3
==========================================
- Hits 9044 9041 -3
- Misses 1719 1724 +5
- Partials 400 405 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@terriko, I think it would handle the error now pretty well. And I have also added a test case where the metrics field is empty to check it. And it works. Is there anything more left to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks like it's ready to go. Thank you! Let's get it merged.
fixes #3209
closes #3208