fix: update nodejs semver in test files to avoid warning #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3207 +/- ##
==========================================
+ Coverage 81.28% 81.45% +0.17%
==========================================
Files 716 716
Lines 11126 11126
Branches 1495 1495
==========================================
+ Hits 9044 9063 +19
+ Misses 1693 1682 -11
+ Partials 389 381 -8
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
novafacing
approved these changes
Aug 9, 2023
|
Thanks @novafacing ! (turns out the warning got auto-dismissed and since it wasn't done by me the alert wouldn't go away on my other dashboard. So now I get to figure out how I turned auto-dismiss on... but this is still a perfectly good PR to merge!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a kind of silly update.
The package-lock.json file we use for language tests has a version of semver that's triggering some CVE warning in one of my dashboards. Normally, I mark these as irrelevant because files in test/language_data are used only for tests of the scanner (the vulnerable code described is never downloaded or used). But for some reason this particular dashboard isn't giving me the usual way to dismiss the warning.
Since fixing that particular private dashboard might take a while, I'm going to try updating the one thing that's throwing an error so I don't have to get daily warnings about this component.
It's possible this change will break the tests. I am running them locally but uploading this PR while I wait so they can happen in parallel.