Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed testing LONG_TESTS on GitHub Actions #308

Merged
merged 11 commits into from
Jan 25, 2020

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Jan 24, 2020

No description provided.

@terriko
Copy link
Contributor Author

terriko commented Jan 25, 2020

Note to self: short tests take 2m, long_tests take 5m, so they're not that long.

@terriko
Copy link
Contributor Author

terriko commented Jan 25, 2020

2 tests at 2m each = 4m
2 tests at 5m each = 10 minutes
2 tests at 2m + 1 test at 5m = 9m

That's not entirely fair because sometimes there's also some delay before the tests run, but I think I'm going with "we're adding python3.8 tests and also they'll run the long tests" anyhow.

We're still more than doubling the time it does to run the tests, which is annoying, but I think it will help with other problems, and it will eventually be required that we run long_tests at least once for coverage anyhow.

@terriko terriko merged commit 231dc5b into intel:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant