Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add libmodbus checker #3002

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

ffontaine
Copy link
Contributor

No description provided.

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #3002 (bf31f3d) into main (06cb2e9) will increase coverage by 0.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
+ Coverage   82.62%   83.36%   +0.73%     
==========================================
  Files         694      696       +2     
  Lines       10754    10764      +10     
  Branches     1430     1430              
==========================================
+ Hits         8886     8973      +87     
+ Misses       1492     1437      -55     
+ Partials      376      354      -22     
Flag Coverage Δ
longtests 82.67% <100.00%> (+5.98%) ⬆️
win-longtests 80.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 91.48% <ø> (ø)
cve_bin_tool/checkers/libmodbus.py 100.00% <100.00%> (ø)
test/test_data/libmodbus.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko
Copy link
Contributor

terriko commented Jun 1, 2023

(I resolved a minor merge conflict so I'll be back to merge after tests finish re-running just in case. They were all passing before the change.)

@terriko
Copy link
Contributor

terriko commented Jun 6, 2023

Merge time!

@terriko terriko merged commit 3c58759 into intel:main Jun 6, 2023
@ffontaine ffontaine deleted the add-libmodbus-checker branch June 7, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants