Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add dmidecode checker #2997

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

ffontaine
Copy link
Contributor

No description provided.

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2997 (a66c394) into main (54da5b0) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
- Coverage   82.45%   82.12%   -0.33%     
==========================================
  Files         672      678       +6     
  Lines       10623    10670      +47     
  Branches     1433     1429       -4     
==========================================
+ Hits         8759     8763       +4     
- Misses       1493     1536      +43     
  Partials      371      371              
Flag Coverage Δ
longtests 82.12% <100.00%> (+6.13%) ⬆️
win-longtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 91.48% <ø> (-3.86%) ⬇️
cve_bin_tool/checkers/dmidecode.py 100.00% <100.00%> (ø)
test/test_data/dmidecode.py 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Test failure was windows short tests, but long tests passed so this should be safe to merge. Thank you!

@terriko terriko merged commit 393d239 into intel:main Jun 1, 2023
@ffontaine ffontaine deleted the add-dmidecode-checker branch June 2, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants