fix: mypy-errors in helper_script.py (#2763) #2873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved all but one type-error in helper_script.py
The remaining mypy-error is due to line 264:
cursor = CVEDB.db_open_and_get_cursor(self)
which gives error
cve_bin_tool/helper_script.py:262: error: Argument 1 to "db_open_and_get_cursor" of "CVEDB" has incompatible type "HelperScript"; expected "CVEDB" [arg-type]
. Later, we also close this connection withCVEDB.db_close(self)
I can think of three ways to resolving this type error:
CVEDB.db_open_and_get_cursor()
andCVEDB.db_close()
static in CVEDB.db_open_and_get_cursor()
anddb_close()
in the helper_script.py.