fix: broken quiet mode in main branch (#1587)

[b31ngd3v]

closes #1587

[codecov-commenter]

Codecov Report

Merging #1648 (728eebc) into main (3daa905) will increase coverage by 2.27%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1648      +/-   ##
==========================================
+ Coverage   78.39%   80.67%   +2.27%     
==========================================
  Files         291      291              
  Lines        6027     6027              
  Branches      989      989              
==========================================
+ Hits         4725     4862     +137     
+ Misses       1086      955     -131     
+ Partials      216      210       -6     

Flag	Coverage Δ
longtests	80.67% <0.00%> (+2.27%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cve_bin_tool/cvedb.py	85.35% <0.00%> (+13.81%)	⬆️
cve_bin_tool/nvd_api.py	70.68% <0.00%> (-13.80%)	⬇️
cve_bin_tool/version_scanner.py	76.35% <0.00%> (+0.77%)	⬆️
cve_bin_tool/extractor.py	59.23% <0.00%> (+1.08%)	⬆️
cve_bin_tool/cli.py	72.72% <0.00%> (+2.59%)	⬆️
cve_bin_tool/checkers/glibc.py	100.00% <0.00%> (+4.16%)	⬆️
cve_bin_tool/available_fix/debian_cve_tracker.py	83.67% <0.00%> (+6.12%)	⬆️
cve_bin_tool/available_fix/redhat_cve_tracker.py	80.35% <0.00%> (+8.92%)	⬆️
test/test_cli.py	91.13% <0.00%> (+10.12%)	⬆️
test/test_scanner.py	74.61% <0.00%> (+12.30%)	⬆️
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[terriko]

Hah, good eye. I'm kind of surprised we didn't see this more often, but I guess since we try to pre-populate the db it just wasn't always doing an update during that test.

[BenL-github]

Oh nice, I looked into this issue awhile back and couldn't solve it. I have a quick question:

I thought quiet mode sets the value of error_mode to NoTrace where NoTrace = 1 (see lines 357-356 of cli.py).
Why does it say in a comment that # error_mode.value will only be greater than 1 if quiet mode If quiet mode has a value of 1?

Also, since lines 323-331 have the same logic, may I apply this fix to that as well? @terriko

[b31ngd3v]

@BenL-github i think you're right, something doesn't add up
edit: one more question-

why self.error_mode.value? i think self.error_mode holds the int value itself.

[terriko]

I suspect all of this code needs a refactor so we're using log levels to determine output all the way through if we can instead of having error_mode at all, but I haven't had time to look at it all and see what would be the right solution. If someone else wants to tackle it, go ahead and start an issue to discuss ideas.