Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run bandit on test code #1579

Merged
merged 6 commits into from
Feb 23, 2022
Merged

ci: run bandit on test code #1579

merged 6 commits into from
Feb 23, 2022

Conversation

rhythmrx9
Copy link
Contributor

closes #1528

@terriko
Copy link
Contributor

terriko commented Feb 16, 2022

This is looking really good. I've approved CI to run and I'll come back to do a code review after it's done.

@rhythmrx9
Copy link
Contributor Author

Thanks, updated the PR as there were merge conflicts.

terriko
terriko approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks like it's working. I note that a couple of long tests are failing, but neither are related to these tests (one is rate limiting and one appears to be a disk i/o error that I'll have to investigate further if it happens regularly.

@terriko
Copy link
Contributor

terriko commented Feb 23, 2022

Thank you!

@terriko terriko merged commit 0976211 into intel:main Feb 23, 2022
@rhythmrx9 rhythmrx9 deleted the bandit branch March 7, 2022 14:36
terriko pushed a commit to terriko/cve-bin-tool that referenced this pull request Mar 9, 2022
@rhythmrx9 @terriko
ci: run bandit on test code (fixes intel#1528) (intel#1579)
80f246f 
* ci: skip assert on tests

* fix: issue B108 in test_scanner.py

* fix: issue B310 in utils.py and test_json.py

* fix: issue B307 in test_input_engine.py and test_merge.py

* doc: update bandit in contributing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improvement: Run bandit on test code
2 participants
@rhythmrx9 @terriko