Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checker): libebml checker #1559

Merged
merged 7 commits into from
Mar 2, 2022
Merged

feat(checker): libebml checker #1559

merged 7 commits into from
Mar 2, 2022

Conversation

rhythmrx9
Copy link
Contributor

Fixes #1298

@rhythmrx9 @BreadGenie
Update cve_bin_tool/checkers/libebml.py
ed57755 
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
@BreadGenie
Copy link
Contributor

@rhythmrx9 you can make sure the tests pass by running LONG_TESTS=1 pytest -k libebml

Also we follow Conventional Commits while creating PRs and writing commit messages. You can refer other PRs.

@rhythmrx9 rhythmrx9 changed the title Added libebml checker New checker: libebml Jan 29, 2022
@rhythmrx9
Copy link
Contributor Author

Tests are passing, thanks.

@rhythmrx9 rhythmrx9 changed the title New checker: libebml feat(checker): libebml checker Jan 30, 2022
terriko
terriko requested changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent. Merging another checker has broken this one, though. do you have time to grab the new version of README/Manual and run format_checkers again?

cve_bin_tool/checkers/libebml.py Outdated Show resolved Hide resolved
@terriko
Copy link
Contributor

terriko commented Mar 2, 2022

This is currently failing the same quiet_mode test that's broken on the main branch and a linting check over commit messages. I'll fix the commit message when I merge.

@terriko terriko merged commit 8837ce6 into intel:main Mar 2, 2022
@rhythmrx9 rhythmrx9 deleted the libebml branch March 7, 2022 14:35
terriko added a commit to terriko/cve-bin-tool that referenced this pull request Mar 9, 2022
@rhythmrx9 @BreadGenie @terriko
feat(checker): libebml checker (fixes intel#1298) (intel#1559)
ffc1917 
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
Co-authored-by: Terri Oda <terri@toybox.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BreadGenie BreadGenie BreadGenie left review comments

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(checker): libebml checker
3 participants
@rhythmrx9 @BreadGenie @terriko