doc: fix incorrect hyperlink (Fixes #1553) #1554
Conversation
Resync repository
chore: update pre-commit config
# Conflicts: # .pre-commit-config.yaml # dev-requirements.txt
…ntel#1517)" This reverts commit 076e16f.
|
@terriko How can a single update to a PDF file result in a failure of the Windows tests? Having said that there does appear to be some deprecation warnings in the error log which are probably worthy of an investigation. |
This is not related to changes in this PR, Windows tests started timing out sometimes. We have a time limit of 20 minutes set and started hitting it recently (not every time though). |
|
Yeah, I agree that the windows issue is unrelated. It's a transient issue where Windows hangs during the tests and times out, but I think it's actually a hang and not a slowdown so there's no point in making the timeout longer. It looked like it normally times out after printing something about the NVD tests which makes me suspect that it's related to the rate limiting that we see in the Linux longtests sometimes, but for some reason Windows isn't getting a 403 http status and fail the test the way it does when that triggers on Linux. If it's rate limiting, the NVD API update should fix it once I can figure out why the key works for me locally but doesn't pass through properly in GitHub Actions. We might also want to dig into whether the requests/urllib2 stuff works differently on windows and force it to have a shorter timeout or something so the test fails instead of hanging, which would help greatly in debugging. None of this has any bearing on fixing the url in your slides, though, so I'm going to go ahead and merge this. Thank you! |
No description provided.