-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Javascript package scanning (Fixes #1453) #1548
Conversation
Resync repository
chore: update pre-commit config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good. I tried to upgrade the type hints, you'll probably want to double-check that I put them in correctly before accepting the suggestions. (see note below on the one I'm not sure about)
Other than improving the type hints, I think this is ready to merge.
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
Co-authored-by: Terri Oda <terri@toybox.ca>
@terriko Happy with the suggestions. version_scanner.py needs type hints to be added to the rest of the functions but that can be picked up as part of the general tidy up of adding type hints across all of the modules. |
Codecov Report
@@ Coverage Diff @@
## main #1548 +/- ##
==========================================
+ Coverage 80.36% 80.95% +0.59%
==========================================
Files 281 282 +1
Lines 5581 5677 +96
Branches 913 938 +25
==========================================
+ Hits 4485 4596 +111
+ Misses 897 865 -32
- Partials 199 216 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looking good. Sorry it's taken me so long to get back to this to get it merged! |
No description provided.