Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for WAR and EAR archive files (#1474) #1478

Merged
merged 25 commits into from
Dec 27, 2021

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1478 (f823e2b) into main (1ddae10) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   82.07%   82.32%   +0.24%     
==========================================
  Files         278      279       +1     
  Lines        5435     5454      +19     
  Branches      882      884       +2     
==========================================
+ Hits         4461     4490      +29     
+ Misses        783      774       -9     
+ Partials      191      190       -1     
Flag Coverage Δ
longtests 82.32% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/extractor.py 64.77% <ø> (ø)
cve_bin_tool/version.py 68.42% <0.00%> (-5.27%) ⬇️
cve_bin_tool/package_list_parser.py 71.66% <0.00%> (-0.24%) ⬇️
test/test_cvescanner.py 100.00% <0.00%> (ø)
cve_bin_tool/cve_scanner.py 84.89% <0.00%> (+8.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ddae10...f823e2b. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure if we should add some explicit tests for these, but I'm guessing that may happen naturally as we get more java support included.

@terriko terriko merged commit ceef627 into intel:main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants