Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: disable jsonschema tests due to NVD data errors #1442

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Nov 12, 2021

The json schema tests are flaky because NVD sometimes provides
non-compliant data. Currently the 2021 yearly file does not pass.

Users wishing to run these checks can still do so locally, but the value
of running failing tests in CI seems minimal so they're being disabled.

* related: intel#1438

The json schema tests are flaky because NVD sometimes provides
non-compliant data.  Currently the 2021 yearly file does not pass.

Users wishing to run these checks can still do so locally, but the value
of running failing tests in CI seems minimal so they're being disabled.
@codecov-commenter
Copy link

Codecov Report

Merging #1442 (994591f) into main (b87bad7) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
- Coverage   82.27%   82.18%   -0.10%     
==========================================
  Files         279      279              
  Lines        5417     5417              
  Branches      675      675              
==========================================
- Hits         4457     4452       -5     
- Misses        773      778       +5     
  Partials      187      187              
Flag Coverage Δ
longtests 82.18% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/nvd_api.py 82.65% <0.00%> (-5.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87bad7...994591f. Read the comment docs.

Copy link
Contributor

@BreadGenie BreadGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at line 177 we can safely remove -n json -u latest.
It was added in #1425
edit: Just saw the reply under #1438. So let's do that change in a separate PR.

Copy link

@antoniogi antoniogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with removing it.

What do you think about adding some kind of info to test_json.py so that if someone runs it manually it reports that running the test might result in an error due to non-compliant data?

Copy link

@antoniogi antoniogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, #1441 does what I mentioned in my previous comment.

@terriko terriko merged commit 5c9aee0 into intel:main Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants