-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Python 3.10 support #1370
Conversation
Resync repository
Codecov Report
@@ Coverage Diff @@
## main #1370 +/- ##
=======================================
Coverage 79.32% 79.32%
=======================================
Files 274 274
Lines 5020 5020
Branches 608 608
=======================================
Hits 3982 3982
Misses 879 879
Partials 159 159
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about testing Windows on 3.10?
And also 3.10 classifier for PyPI tags here.
.github/workflows/pythonapp.yml
Outdated
@@ -66,7 +66,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest] | |||
python: [3.6, 3.7, 3.9] | |||
python: [3.6, 3.7, 3.9, 3.10] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python: [3.6, 3.7, 3.9, 3.10] | |
python: ['3.6', '3.7', '3.9', '3.10'] |
This will fix the CI.
Aha, it still fails, you'll need to update |
@Molkree Linux now works but 3.10 on windows fails on the installation of pycares. |
@anthonyharrison, you will need to install While at it might as well update python -m pip install --upgrade setuptools wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! So glad to see that you only had to update CI and not the code. :)
No description provided.