Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Python 3.10 support #1370

Merged
merged 29 commits into from
Oct 12, 2021
Merged

feat: Add Python 3.10 support #1370

merged 29 commits into from
Oct 12, 2021

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2021

Codecov Report

Merging #1370 (04f7d10) into main (b95e288) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   79.32%   79.32%           
=======================================
  Files         274      274           
  Lines        5020     5020           
  Branches      608      608           
=======================================
  Hits         3982     3982           
  Misses        879      879           
  Partials      159      159           
Flag Coverage Δ
longtests 79.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95e288...04f7d10. Read the comment docs.

Copy link
Contributor

@Molkree Molkree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about testing Windows on 3.10?
And also 3.10 classifier for PyPI tags here.

@@ -66,7 +66,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
python: [3.6, 3.7, 3.9]
python: [3.6, 3.7, 3.9, 3.10]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python: [3.6, 3.7, 3.9, 3.10]
python: ['3.6', '3.7', '3.9', '3.10']

This will fix the CI.

@Molkree
Copy link
Contributor

Molkree commented Oct 10, 2021

Aha, it still fails, you'll need to update uses: actions/setup-python@v1 to v2, @anthonyharrison

@anthonyharrison
Copy link
Contributor Author

Aha, it still fails, you'll need to update uses: actions/setup-python@v1 to v2, @anthonyharrison

@Molkree Linux now works but 3.10 on windows fails on the installation of pycares.

@Molkree
Copy link
Contributor

Molkree commented Oct 10, 2021

but 3.10 on windows fails on the installation of pycares

@anthonyharrison, you will need to install wheel package to build packages properly. I think it will be good to do the same even on Ubuntu because right now it is Using legacy 'setup.py install' for <some packages>, since package 'wheel' is not installed.

While at it might as well update setuptools but it might be not needed (I haven't tested without updating though).
Just add this in the "Install dependencies" step:

          python -m pip install --upgrade setuptools wheel

Test run in my fork.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So glad to see that you only had to update CI and not the code. :)

@terriko terriko merged commit 7f562ed into intel:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants