Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: autoupdate pre-commit config #1302

Merged
merged 1 commit into from
Aug 4, 2021
Merged

ci: autoupdate pre-commit config #1302

merged 1 commit into from
Aug 4, 2021

Conversation

Molkree
Copy link
Contributor

@Molkree Molkree commented Aug 2, 2021

Per @terriko #1260 (comment):

I can't authorize pre-commit.ci for this repo because it's managed by Intel, so let's focus on getting things working in github actions as is for now.

If pre-commit.ci is not an option (yet?), this workflow can be used to autoupdate pre-commit config.

Here is an example of generated PR.

The body of the PR can be tweaked as well, just don't know if you want something more meaningful.

P.S. If pre-commit hooks will be kept up to date with this workflow it would probably make more sense to unpin Black in dev-requirements.txt

black==20.8b1

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #1302 (f2e77be) into main (8e2cd7c) will decrease coverage by 2.13%.
The diff coverage is 15.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
- Coverage   81.26%   79.13%   -2.14%     
==========================================
  Files         270      271       +1     
  Lines        4826     4864      +38     
  Branches      575      585      +10     
==========================================
- Hits         3922     3849      -73     
- Misses        759      863     +104     
- Partials      145      152       +7     
Flag Coverage Δ
longtests 79.13% <15.87%> (-2.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/format_checkers.py 0.00% <0.00%> (ø)
cve_bin_tool/version.py 78.94% <0.00%> (+8.94%) ⬆️
test/test_cli.py 81.99% <25.00%> (-11.38%) ⬇️
cve_bin_tool/cvedb.py 82.42% <80.00%> (-0.61%) ⬇️
cve_bin_tool/cve_scanner.py 76.22% <100.00%> (-1.12%) ⬇️
cve_bin_tool/version_scanner.py 74.30% <100.00%> (-1.39%) ⬇️
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
test/test_scanner.py 61.71% <0.00%> (-12.50%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10d65c...f2e77be. Read the comment docs.

.github/workflows/update-pre-commit.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terriko terriko merged commit 3054869 into intel:main Aug 4, 2021
@Molkree Molkree deleted the autoupdate-pre-commit branch August 4, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants