Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): libvncserver checker #1296

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

peb-peb
Copy link
Contributor

@peb-peb peb-peb commented Aug 1, 2021

Description

Added libvncserver checker

Checklist

  • Add checker
  • All tests passing
  • black/isort tests are passing
  • updated the template for this checker
  • updated the reference links
  • added condensed downloads

@codecov-commenter
Copy link

Codecov Report

Merging #1296 (eacded6) into main (281cd76) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   80.35%   80.39%   +0.03%     
==========================================
  Files         264      266       +2     
  Lines        4810     4819       +9     
  Branches      578      578              
==========================================
+ Hits         3865     3874       +9     
  Misses        797      797              
  Partials      148      148              
Flag Coverage Δ
longtests 80.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.45% <ø> (ø)
cve_bin_tool/checkers/libvncserver.py 100.00% <100.00%> (ø)
test/test_data/libvncserver.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281cd76...eacded6. Read the comment docs.

"product": "libvncserver",
"version": "0.9.13",
},
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need 5 different packages to test?
Maybe I'm wrong but I think we only add more packages when the version strings are different in different versions or packages (like in systemd).
IMO adding couple packages with different packages and extensions is fine (maybe it's okay now that long tests take less time).

Offtopic: Glad to have you back here :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offtopic: Glad to have you back here :D

Thanks :D

I think that the 5 different packages would show that these packages are valid across all different distros, i.e., centos, fedora, debian, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the different distros, but usually we try to also get some different versions at the same time (might as well prove as many things as possible per test). I'm going to go ahead and approve and merge this as is, but I'll open an issue to suggest that maybe we could swap a few versions in the future.

@peb-peb
Copy link
Contributor Author

peb-peb commented Aug 1, 2021

Please give your suggestions on if something else should be added in the template.

@BreadGenie
Copy link
Contributor

maybe add a check for checker too (even though it's obvious) like in #1076 (my 1st contribution :D).

"product": "libvncserver",
"version": "0.9.13",
},
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the different distros, but usually we try to also get some different versions at the same time (might as well prove as many things as possible per test). I'm going to go ahead and approve and merge this as is, but I'll open an issue to suggest that maybe we could swap a few versions in the future.

@terriko terriko merged commit 8e2cd7c into intel:main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants