-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checker): libvncserver checker #1296
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
+ Coverage 80.35% 80.39% +0.03%
==========================================
Files 264 266 +2
Lines 4810 4819 +9
Branches 578 578
==========================================
+ Hits 3865 3874 +9
Misses 797 797
Partials 148 148
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
"product": "libvncserver", | ||
"version": "0.9.13", | ||
}, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need 5 different packages to test?
Maybe I'm wrong but I think we only add more packages when the version strings are different in different versions or packages (like in systemd).
IMO adding couple packages with different packages and extensions is fine (maybe it's okay now that long tests take less time).
Offtopic: Glad to have you back here :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offtopic: Glad to have you back here :D
Thanks :D
I think that the 5 different packages would show that these packages are valid across all different distros, i.e., centos, fedora, debian, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the different distros, but usually we try to also get some different versions at the same time (might as well prove as many things as possible per test). I'm going to go ahead and approve and merge this as is, but I'll open an issue to suggest that maybe we could swap a few versions in the future.
Please give your suggestions on if something else should be added in the template. |
maybe add a check for checker too (even though it's obvious) like in #1076 (my 1st contribution :D). |
"product": "libvncserver", | ||
"version": "0.9.13", | ||
}, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the different distros, but usually we try to also get some different versions at the same time (might as well prove as many things as possible per test). I'm going to go ahead and approve and merge this as is, but I'll open an issue to suggest that maybe we could swap a few versions in the future.
Description
Added libvncserver checker
Checklist