Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark failing nvd test as skipped (for now) #1286

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Jul 28, 2021

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1286 (ac297b7) into main (84ba5a0) will decrease coverage by 2.19%.
The diff coverage is 66.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1286      +/-   ##
==========================================
- Coverage   81.09%   78.90%   -2.20%     
==========================================
  Files         260      262       +2     
  Lines        4580     4801     +221     
  Branches      552      578      +26     
==========================================
+ Hits         3714     3788      +74     
- Misses        728      859     +131     
- Partials      138      154      +16     
Flag Coverage Δ
longtests 78.90% <66.38%> (-2.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cvedb.py 82.42% <50.00%> (-2.93%) ⬇️
cve_bin_tool/nvd_api.py 63.28% <63.28%> (ø)
test/test_nvd_api.py 66.66% <66.66%> (ø)
cve_bin_tool/cve_scanner.py 77.34% <95.45%> (+1.71%) ⬆️
cve_bin_tool/cli.py 75.30% <100.00%> (-2.89%) ⬇️
cve_bin_tool/error_handler.py 88.70% <100.00%> (+0.18%) ⬆️
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
test/test_scanner.py 61.71% <0.00%> (-12.50%) ⬇️
test/test_cli.py 81.28% <0.00%> (-11.83%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84738c2...ac297b7. Read the comment docs.

@terriko terriko merged commit 2d69f84 into intel:main Jul 28, 2021
peb-peb pushed a commit to peb-peb/cve-bin-tool that referenced this pull request Aug 2, 2021
Disables test_api_cve_count until it can be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants