Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename development requirements file for Snyk #1272

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Jul 22, 2021

Snyk picks up files named *req*.txt so we're switching
dev-recommended.txt to dev-requirements.txt so it gets scanned
automatically.

Snyk picks up files named `*req*.txt` so we're switching
dev-recommended.txt to dev-requirements.txt so gets scanned
automatically.

Signed-off-by: Terri Oda <terri@toybox.ca>
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #1272 (59079d1) into main (4449279) will decrease coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1272      +/-   ##
==========================================
- Coverage   80.74%   79.22%   -1.52%     
==========================================
  Files         252      252              
  Lines        4564     4564              
  Branches      557      557              
==========================================
- Hits         3685     3616      -69     
- Misses        741      802      +61     
- Partials      138      146       +8     
Flag Coverage Δ
longtests 79.22% <ø> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
test/test_scanner.py 61.71% <0.00%> (-12.50%) ⬇️
test/test_cli.py 81.28% <0.00%> (-11.83%) ⬇️
cve_bin_tool/checkers/glibc.py 95.83% <0.00%> (-4.17%) ⬇️
cve_bin_tool/cli.py 75.15% <0.00%> (-3.04%) ⬇️
cve_bin_tool/version_scanner.py 76.38% <0.00%> (-1.39%) ⬇️
cve_bin_tool/cvedb.py 84.39% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4449279...59079d1. Read the comment docs.

@terriko terriko requested a review from antoniogi July 22, 2021 23:13
@terriko terriko merged commit c71cd03 into intel:main Jul 26, 2021
peb-peb pushed a commit to peb-peb/cve-bin-tool that referenced this pull request Aug 2, 2021
* fix: rename development requirements file for Snyk

Snyk picks up files named `*req*.txt` so we're switching
dev-recommended.txt to dev-requirements.txt so gets scanned
automatically.

Signed-off-by: Terri Oda <terri@toybox.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants