-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(merge): Add filter for intermediate reports #1262
Conversation
Sorry, looks like merging #1218 made some minor merge conflicts here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have an entry in the manual explaining why the user would want this. Is the expectation that they'll have all the reports in a directory and merge them all every time, and might just want to exclude one without moving the file(s) with that tag out of the directory? What circumstances would make this useful? Are you thinking "what if you had nightly scans but you only wanted to show the ones per week" or something else?
2b5c281
to
3ae39f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 79.35% 79.31% -0.04%
==========================================
Files 271 271
Lines 4902 4908 +6
Branches 591 593 +2
==========================================
+ Hits 3890 3893 +3
- Misses 865 866 +1
- Partials 147 149 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Looks good! I really like the new docs. We might want to consider putting --merge and --filter into their own argument group to make it more clear that they go together, but I'll file a separate issue for that. |
I have added a filter for intermediate reports which will filter out reports from the merge output.
Do users want to filter out the reports on the basis of a date range as well? If that is the case, should I add
-s --start-date
and-e --end-date
arguments. Or should I just convert-F --filter
to a dictionary type input.?