Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): Add sudo checker #1259

Merged
merged 2 commits into from
Jul 21, 2021
Merged

feat(checker): Add sudo checker #1259

merged 2 commits into from
Jul 21, 2021

Conversation

imsahil007
Copy link
Contributor

No description provided.

@imsahil007
Copy link
Contributor Author

fixes #1072

@imsahil007
Copy link
Contributor Author

I think this still needs improvement before merging

@codecov-commenter
Copy link

Codecov Report

Merging #1259 (77a12bf) into main (e8b8384) will increase coverage by 1.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   76.58%   78.29%   +1.70%     
==========================================
  Files         240      242       +2     
  Lines        4502     4511       +9     
  Branches      559      559              
==========================================
+ Hits         3448     3532      +84     
+ Misses        907      841      -66     
+ Partials      147      138       -9     
Flag Coverage Δ
longtests 78.29% <100.00%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.55% <ø> (ø)
cve_bin_tool/checkers/sudo.py 100.00% <100.00%> (ø)
test/test_data/sudo.py 100.00% <100.00%> (ø)
cve_bin_tool/version_scanner.py 77.24% <0.00%> (+1.37%) ⬆️
cve_bin_tool/cvedb.py 86.62% <0.00%> (+2.22%) ⬆️
cve_bin_tool/cli.py 78.18% <0.00%> (+3.03%) ⬆️
cve_bin_tool/checkers/glibc.py 100.00% <0.00%> (+3.70%) ⬆️
cve_bin_tool/checkers/systemd.py 92.59% <0.00%> (+7.40%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b8384...77a12bf. Read the comment docs.

@BreadGenie
Copy link
Contributor

According to #1072 (comment) there might be a package with only viable version string in multiple lines so it'll be worth it to look into that after #1227 is merged

@terriko terriko merged commit 6248aef into intel:main Jul 21, 2021
peb-peb pushed a commit to peb-peb/cve-bin-tool that referenced this pull request Aug 2, 2021
* feat(checker): Add sudo checker

* add condensed downloads for sudo
@ffontaine ffontaine mentioned this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants