Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests for test_helper_script #1255

Merged
merged 2 commits into from
Jul 19, 2021
Merged

fix: tests for test_helper_script #1255

merged 2 commits into from
Jul 19, 2021

Conversation

peb-peb
Copy link
Contributor

@peb-peb peb-peb commented Jul 16, 2021

this should close #1254

While iterating over helperscript, I updated the parse_filename() to return both product and version, but forgot to update the tests for it :(

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #1255 (c48f3de) into main (38c42be) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1255   +/-   ##
=======================================
  Coverage   76.57%   76.58%           
=======================================
  Files         240      240           
  Lines        4495     4501    +6     
  Branches      558      559    +1     
=======================================
+ Hits         3442     3447    +5     
- Misses        907      908    +1     
  Partials      146      146           
Flag Coverage Δ
longtests 76.58% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_helper_script.py 0.00% <0.00%> (ø)
test/test_checkers.py 96.61% <0.00%> (-1.47%) ⬇️
cve_bin_tool/cvedb.py 84.07% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c42be...c48f3de. Read the comment docs.

test/test_helper_script.py Outdated Show resolved Hide resolved
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! I'll update #1251 so these are actually running after it's merged, then.

@terriko terriko merged commit 792280b into intel:main Jul 19, 2021
peb-peb added a commit to peb-peb/cve-bin-tool that referenced this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests in test_helper_script.py are failing
4 participants