Fix yaml and toml tests in test_config #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
+ Coverage 78.80% 79.36% +0.55%
==========================================
Files 240 240
Lines 4501 4501
Branches 559 559
==========================================
+ Hits 3547 3572 +25
+ Misses 804 781 -23
+ Partials 150 148 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Closed
* Related to intel#1159 Two of the tests in test_config were failing, presumably because they'd gotten out of date when we changed the default for extraction. These tests were not being run in CI (thanks to @Molkree for noting that) so they didn't get fixed in a timely manner. Signed-off-by: Terri Oda <terri.oda@intel.com>
|
No one had any objections to merging this in our weekly meeting, so I'm going to go ahead and do that now so that these tests are running again. |
peb-peb
pushed a commit
to peb-peb/cve-bin-tool
that referenced
this pull request
Aug 2, 2021
* Fix yaml and toml tests in test_config * Related to intel#1159 * Add test_config back to updated CI Two of the tests in test_config were failing, presumably because they'd gotten out of date when we changed the default for extraction. These tests were not being run in CI (thanks to @Molkree for noticing that) so they didn't get fixed in a timely manner. Signed-off-by: Terri Oda <terri.oda@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the tests in test_config were failing, presumably because they'd
gotten out of date when we changed the default for extraction. These
tests were not being run in CI (thanks to @Molkree for noting that) so
they didn't get fixed in a timely manner.
Signed-off-by: Terri Oda terri.oda@intel.com