fix(security): Improve SQL in version_signature.py #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improves version_signature.py to align with bandit's guidance * fixes intel#1229 Signed-off-by: Terri Oda <terri.oda@intel.com>
You can't use bound parameters for things like table names that aren't technically parameters in sqlite3. Moved some basic input validation into the init function and marked lines for bandit. Because bandit doesn't deal well with multi-lines with `nosec` comments, I've added descriptive comments to some select statements. Signed-off-by: Terri Oda <terri.oda@intel.com>
Codecov Report
@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
- Coverage 78.29% 76.60% -1.70%
==========================================
Files 243 243
Lines 4496 4500 +4
Branches 557 558 +1
==========================================
- Hits 3520 3447 -73
- Misses 840 907 +67
- Partials 136 146 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pdxjohnny
reviewed
Jul 14, 2021
pdxjohnny
approved these changes
Jul 14, 2021
Co-authored-by: John Andersen <johnandersenpdx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't use bound parameters for things like table names that aren't technically parameters in sqlite3, but Bandit throws errors due to the string construction in queries. Added some basic input validation into the init function and marked lines for Bandit. Because bandit doesn't deal well with multi-lines with
noseccomments, I've added descriptive comments to some select statements instead of the# nosecline that would make the line disappear from future runs of Bandit.Signed-off-by: Terri Oda terri.oda@intel.com