Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): Add gupnp Checker #1236

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

BreadGenie
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Merging #1236 (a2392fc) into main (323809e) will decrease coverage by 0.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
- Coverage   79.34%   78.38%   -0.96%     
==========================================
  Files         223      225       +2     
  Lines        4197     4377     +180     
  Branches      517      549      +32     
==========================================
+ Hits         3330     3431     +101     
- Misses        734      811      +77     
- Partials      133      135       +2     
Flag Coverage Δ
longtests 78.38% <100.00%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.55% <ø> (ø)
test/test_data/__init__.py 100.00% <ø> (ø)
cve_bin_tool/checkers/gupnp.py 100.00% <100.00%> (ø)
test/test_data/gupnp.py 100.00% <100.00%> (ø)
cve_bin_tool/output_engine/html.py 57.57% <0.00%> (-32.17%) ⬇️
cve_bin_tool/output_engine/print_mode.py 78.57% <0.00%> (-7.15%) ⬇️
cve_bin_tool/output_engine/pdfbuilder.py 31.48% <0.00%> (-5.29%) ⬇️
cve_bin_tool/version.py 70.00% <0.00%> (-5.00%) ⬇️
cve_bin_tool/cli.py 78.18% <0.00%> (-0.22%) ⬇️
test/test_output_engine.py 98.29% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323809e...a2392fc. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@terriko terriko merged commit 168e16b into intel:main Jul 14, 2021
@BreadGenie BreadGenie deleted the gupnp-checker branch July 14, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants