Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checker): Add enscript Checker #1216

Merged
merged 1 commit into from
Jul 7, 2021
Merged

feat(checker): Add enscript Checker #1216

merged 1 commit into from
Jul 7, 2021

Conversation

BreadGenie
Copy link
Contributor

@BreadGenie BreadGenie marked this pull request as draft July 4, 2021 13:20
@BreadGenie BreadGenie marked this pull request as ready for review July 4, 2021 13:20
terriko
terriko reviewed Jul 7, 2021
View reviewed changes
test/test_data/__init__.py
@@ -16,6 +16,7 @@
"dnsmasq",
"dovecot",
"dpkg",
"enscript",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you have to add the checker in two init.py files. Is there any way we could make it so we only have one canonical list of checkers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed issue #1223 to look into this later, since it's not something that needs to be fixed in this checker specifically.

terriko
terriko approved these changes Jul 7, 2021
View reviewed changes
test/test_data/__init__.py
@@ -16,6 +16,7 @@
"dnsmasq",
"dovecot",
"dpkg",
"enscript",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed issue #1223 to look into this later, since it's not something that needs to be fixed in this checker specifically.

@terriko
Copy link
Contributor

terriko commented Jul 7, 2021

Failing tests are the ones fixed in #1215

@terriko terriko merged commit b94cc01 into intel:main Jul 7, 2021
@BreadGenie BreadGenie deleted the enscript-checker branch July 7, 2021 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BreadGenie @terriko