feat: Add recommdended dev tools list #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved isort as per last week's meeting discussion. |
Signed-off-by: Terri Oda <terri@toybox.ca>
Signed-off-by: Terri Oda <terri@toybox.ca>
Signed-off-by: Terri Oda <terri@toybox.ca>
|
If you add |
|
@Molkree I wasn't going to bother, because users aren't going to be using those and we've got dependabot, but now that you mention it since this file is called dev-recommended.txt instead of dev-requirements.txt I'm not sure that's going to get picked up. Might have to open an issue to check that. |
peb-peb
pushed a commit
to peb-peb/cve-bin-tool
that referenced
this pull request
Aug 2, 2021
* Add recommdended dev tools list * Moved isort to dev requirements file. * fix: pip install from dev-recommended for isort CI * fix: remove isort also from requirements.csv Signed-off-by: Terri Oda <terri@toybox.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds what is basically requirements.txt file for developers, including the specific version of black that we're currently using and pre-commit (which will help you run black and isort)
We may want to move isort into this list, since I believe it's also only needed for developers.