Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package-list-parser): Ubuntu #1183

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Conversation

BreadGenie
Copy link
Contributor

@BreadGenie BreadGenie commented Jun 19, 2021

#1018

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #1183 (4a6112b) into main (fce0bc8) will increase coverage by 0.10%.
The diff coverage is 94.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
+ Coverage   82.05%   82.15%   +0.10%     
==========================================
  Files         202      202              
  Lines        3695     3733      +38     
  Branches      438      446       +8     
==========================================
+ Hits         3032     3067      +35     
- Misses        542      544       +2     
- Partials      121      122       +1     
Flag Coverage Δ
longtests 82.15% <94.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/package_list_parser/__init__.py 92.30% <92.59%> (-1.67%) ⬇️
cve_bin_tool/error_handler.py 88.33% <100.00%> (ø)
cve_bin_tool/package_list_parser/vendor_fetch.py 96.00% <100.00%> (+0.16%) ⬆️
test/test_package_list_parser.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce0bc8...4a6112b. Read the comment docs.

@BreadGenie
Copy link
Contributor Author

BreadGenie commented Jun 19, 2021

The parser takes an input of list of files with package names similar to requirements.txt file format. Refer test_ubuntu_list.txt

When the package list is long it'll take quite some time to fetch the vendors. So instead of looking at a blank screen, a progress bar would be helpful to know that the tool is not stuck/hanging somewhere for the users.
@terriko terriko merged commit 9c36968 into intel:main Jun 23, 2021
@BreadGenie BreadGenie deleted the ubuntu-parser branch June 23, 2021 21:16
@BreadGenie BreadGenie changed the title Ubuntu package list parser feat(package-list-parser): Debian based distro support Aug 17, 2021
@BreadGenie BreadGenie changed the title feat(package-list-parser): Debian based distro support feat(package-list-parser): Ubuntu Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants