Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper decoding of stdout in condensed download committed or not test #1172

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

BreadGenie
Copy link
Contributor

@BreadGenie BreadGenie commented Jun 12, 2021

While working on #1165 I noticed that improper decoding of stdout could cause problems in different platforms (had issues on windows). Instead of splitting the string for parsing of the stdout it is properly decoded now.

Instead of hacky parsing of the output it is properly decoded now and tidy up comments.
@codecov-commenter
Copy link

Codecov Report

Merging #1172 (cc0c4ba) into main (7b95f5a) will decrease coverage by 2.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1172      +/-   ##
==========================================
- Coverage   82.14%   79.79%   -2.36%     
==========================================
  Files         196      197       +1     
  Lines        3383     3484     +101     
  Branches      381      408      +27     
==========================================
+ Hits         2779     2780       +1     
- Misses        512      595      +83     
- Partials       92      109      +17     
Flag Coverage Δ
longtests 79.79% <100.00%> (-2.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_condensed_downloads.py 100.00% <100.00%> (ø)
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
test/test_scanner.py 61.71% <0.00%> (-12.50%) ⬇️
test/test_cli.py 81.28% <0.00%> (-11.83%) ⬇️
cve_bin_tool/checkers/systemd.py 85.18% <0.00%> (-7.41%) ⬇️
cve_bin_tool/checkers/glibc.py 96.29% <0.00%> (-3.71%) ⬇️
cve_bin_tool/extractor.py 60.15% <0.00%> (-3.13%) ⬇️
cve_bin_tool/cli.py 83.33% <0.00%> (-2.90%) ⬇️
cve_bin_tool/version_scanner.py 82.20% <0.00%> (-1.70%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b95f5a...cc0c4ba. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not sure if we'll run into trouble if we wind up with packages that have non-utf-8 in them but that's a problem for future us.

@terriko terriko merged commit 1cfc167 into intel:main Jun 15, 2021
@BreadGenie BreadGenie deleted the proper-decode branch June 16, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants