Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright/spdx license information header to all python files #1098

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Mar 18, 2021

This adds the recommended copyright/spdx information to all python files in cve-bin-tool. (This is in preparation for merging #1091 once I get approval from our licensing team; they recommend we display any additional licenses at the top below our SPDX info, but ours was missing, so I'm fixing that first.)

For the record, I used the following bash script to do this:

for a in `find . -name "*.py"`; do echo "===" $a; cat spdx_header.txt > /tmp/spdx; cat $a >> /tmp/spdx; cp /tmp/spdx $a; done

And then used a variant of that to git add all the files once I'd checked them.

@terriko terriko requested a review from pdxjohnny March 18, 2021 23:21
@terriko
Copy link
Contributor Author

terriko commented Mar 18, 2021

Pinging @pdxjohnny for review. Not that there's code to review here, but I wouldn't mind a second opinion on whether we should remove the shebang (#!/usr/bin/python) lines from the few files where we have them, or possibly move the shebang to occur before the license info. I don't think it has much functional effect since most people would never try to run those files separately so it's basically a comment in most contexts, but it seems inelegant.

@terriko
Copy link
Contributor Author

terriko commented Mar 22, 2021

No comment from @pdxjohnny but I think I'm going to get this merged as-is since the licensing folk recommended it, and we'll decide about the #!/usr/bin/python3 lines later.

@terriko terriko merged commit 2bf5f7a into intel:main Mar 22, 2021
@Molkree
Copy link
Contributor

Molkree commented May 12, 2021

Any decision on shebang lines? I see there are 5 files left with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants