-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit aiohttp simultaneously opened connections to NVD #1093
Conversation
might fix #1081 |
Hey @imsahil007!
Point being that I would note however, that this is all based on conjecture, so I might be wrong ;) |
Yes, I am decreasing the number of simultaneous connections that make separate requests. So, it will decrease the requests per unit time as the connections are lower than the default value of 50. You can say that |
We're having a bit of a discussion about which of the two currently working solutions to #1081 is going to be most robust before I choose one. But in the meantime, do you mind splitting the isort fixes into a separate pull request? We can definitely get those merged so they don't muddy up anyone else's pull requests! |
Because #1091 introduces a new MIT-licensed component, I've got some additional paperwork to do before I can merge it to make sure we have appropriate license compliance and follow best practices for making sure the license is clear. I'm going to merge this fix for now just so CI isn't broken, but I believe that the rate limit proposed in #1091 is useful (this PR is a connection limit) so we'll be integrating them to play well together after I deal with the licensing work. |
Pull request by @param211 #1091 can be an alternate solution for #1081.
But I manually tried limiting connections to NVD. And it seems like NVD allows a maximum limit of 20 per host.
This worked for me every time.
I am just putting it here as a feasible solution @terriko
Also, the only files I changed is cvedb.py and test_cvedb.py (Other changes are related to isort)