mysql version pattern bug #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terriko
requested changes
Jan 27, 2021
cve_bin_tool/checkers/mysql.py
Outdated
| @@ -28,3 +28,12 @@ class MysqlChecker(Checker): | |||
| ] | |||
| VERSION_PATTERNS = [r"mysql\-([0-9]+\.[0-9]+\-[0-9]+\.[0-9]+\.[0-9]+)"] | |||
There was a problem hiding this comment.
What you've got will work, but wouldn't it be easier to change the pattern here? the part we treat as a version is what's matched inside the round brackets () so if we want to discard the first part entirely, we could just move that first bracket:
Suggested change
| VERSION_PATTERNS = [r"mysql\-([0-9]+\.[0-9]+\-[0-9]+\.[0-9]+\.[0-9]+)"] | |
| VERSION_PATTERNS = [r"mysql\-[0-9]+\.[0-9]+\-([0-9]+\.[0-9]+\.[0-9]+)"] |
Or will that break some older parsing?
There was a problem hiding this comment.
It didn't break the parsing. I made the changes
terriko
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysql checker was recognizing version syntax 8.0.20 as 8.0.8.0.20. Currently we are only recognising the pattern
mysql\-([0-9]+\.[0-9]+\-[0-9]+\.[0-9]+\.[0-9]+)These changes will give us the exact version
This will close #954