Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test that fails if any VENDOR_PRODUCT in checker is not lowercase #987

Closed
terriko opened this issue Nov 19, 2020 · 6 comments
Closed
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@terriko
Copy link
Contributor

terriko commented Nov 19, 2020

The matching on vendor product pairs in the database is case-sensitive. We could change that, but I feel like it probably makes more sense to catch that at the point when checkers are committed rather than add string operations that we don't really need.

In practice, checkers don't work if you use capital letters in this field, but it's not inherently obvious to new contributors why things are failing. It would be really nice if we had a short test that just went through the checkers to see if any weren't lowercase, and printed a meaningful "checker X has a VENDOR_PRODUCT string that is not lowercase" type message.

@terriko terriko added the good first issue Good for newcomers label Nov 19, 2020
@utkarsh147-del
Copy link
Contributor

I want to work in this.Please assign this issue to me.

@utkarsh147-del
Copy link
Contributor

Please assign this to me mam.I will surely do this.

@pdxjohnny
Copy link
Member

@utkarsh147-del We don't have the ability to assign issue to non-Intel users. The best way to communicate your desire to work on something is to comment in the issue as you've done. However, you only need to say that you are going to work on something, you don't have to ask first unless someone else commented and they might be working on it.

The next step is to create a draft PR so that maintainers and others know that you are making progress.

Thanks!

@terriko
Copy link
Contributor Author

terriko commented Nov 25, 2020

Actually, it turns out we can assign things to people if they comment on the bug. So I have, if it makes you feel better to have it assigned!

But generally, @pdxjohnny is correct: we don't bother to assign bugs in this project. As John says, if you're interested, comment saying so and start up a pull request so people know you're making progress. If there's no active pull request and it's been more than a week since you said you wanted the issue, it's possible it will be re-assigned to someone else.

@terriko terriko added this to the 2.2 milestone Nov 25, 2020
@utkarsh147-del
Copy link
Contributor

utkarsh147-del commented Nov 26, 2020 via email

chaitanyamogal added a commit to chaitanyamogal/cve-bin-tool that referenced this issue Jan 21, 2021
The test fails when the `VENDOR_PRODUCT` pair provided is not lowercase. ( intel#987 )
@terriko
Copy link
Contributor Author

terriko commented Jan 27, 2021

Fixed in #1032

@terriko terriko closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants