Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize relative/non-relative imports #659

Closed
terriko opened this issue May 12, 2020 · 4 comments
Closed

Normalize relative/non-relative imports #659

terriko opened this issue May 12, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented May 12, 2020

A comment in #656 reminded me: we currently have some places that use from cve_bin_tool. {...} import and some that use from .. import -- we should probably normalize those so they're consistent.
@Niraj-Kamdar
Copy link
Contributor

We should use relative imports everywhere

@terriko
Copy link
Contributor Author

terriko commented May 13, 2020

Agreed! I didn't realize I hadn't expressed a preferred action in the issue. whoops.

@Niraj-Kamdar
Copy link
Contributor

This should be labeled as good first issue

@terriko terriko added the good first issue Good for newcomers label May 19, 2020
sakshatshinde added a commit to sakshatshinde/cve-bin-tool that referenced this issue May 21, 2020
@sakshatshinde
Normalizing imports
c4802e7 
Normalizing relative / non-relative imports in cvedb.py and extractor.py 

Reference : Issue intel#659
@sakshatshinde sakshatshinde mentioned this issue May 21, 2020
Merged
@sakshatshinde
Copy link
Contributor

I have opened a pull request regarding this issue :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@terriko @sakshatshinde @Niraj-Kamdar