Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertEquals in test_csv2cve.py #342

Closed
terriko opened this issue Feb 10, 2020 · 0 comments · Fixed by #343
Closed

Fix assertEquals in test_csv2cve.py #342

terriko opened this issue Feb 10, 2020 · 0 comments · Fixed by #343
Labels
good first issue Good for newcomers gsoc Tasks related to our participation in Google Summer of Code

Comments

@terriko
Copy link
Contributor

terriko commented Feb 10, 2020

This is a very beginner-friendly bug suitable for someone who doesn't have any commits yet. Please don't bother to fix this one if you've already got commits -- it's really not urgent.

I basically made a typo in test_csv2cve that generates a warning in pytest:

================================================= warnings summary ==================================================
test/test_csv2cve.py::TestCsv2cve::test_main
  /home/terri/Code/cve-bin-tool/test/test_csv2cve.py:53: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(0, returncode)

-- Docs: https://docs.pytest.org/en/latest/warnings.html

----------- coverage: platform linux, python 3.6.8-final-0 -----------
Coverage XML written to file coverage.xml

===================================== 92 passed, 1 warning in 732.06s (0:12:12) =====================================

If you look at that warning, it pretty much tells you exactly what to do and where to find the issue! It should be a one line fix.

@terriko terriko added good first issue Good for newcomers gsoc Tasks related to our participation in Google Summer of Code labels Feb 10, 2020
shreyamalviya added a commit to shreyamalviya/cve-bin-tool that referenced this issue Feb 11, 2020
terriko pushed a commit that referenced this issue Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gsoc Tasks related to our participation in Google Summer of Code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant