You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cli.py and helper_script.py use ArgumentParser and that's great, however they both keep default arguments in the separatedict instead of specifying them right when adding an argument to the parser. This reduces locality and prevents us from showing default in the help string with %(default)s.
I was told this is due to the fact that CLI supports reading config from file however I believe this should still work nicely with config files if you replace defaults dict with something like defaults = {key: parser.get_default(key) for key in vars(args)}.
The text was updated successfully, but these errors were encountered:
As mentioned in #1333 (comment) and #1340 (comment).
cli.py and helper_script.py use
ArgumentParser
and that's great, however they both keep default arguments in the separate dict instead of specifying them right when adding an argument to the parser. This reduces locality and prevents us from showing default in the help string with%(default)s
.I was told this is due to the fact that CLI supports reading config from file however I believe this should still work nicely with config files if you replace
defaults
dict with something likedefaults = {key: parser.get_default(key) for key in vars(args)}
.The text was updated successfully, but these errors were encountered: