Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-6214 - bump aws rds version #697

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

valerymo
Copy link
Contributor

Overview

Jira: https://issues.redhat.com/browse/MGDAPI-6214

Verification

  • Clone this branch
  • Run make cluster/prepare
  • Run make run
  • Ensure...

Checklist

  • This PR includes a change to an instance type, I have used script hack/<provider>/supported_types.sh and attached the result below

@@ -62,7 +62,7 @@ const (
)

var (
defaultSupportedEngineVersions = []string{"13.8", "13.4", "10.18", "10.16", "10.15", "10.13", "10.6", "9.6", "9.5"}
defaultSupportedEngineVersions = []string{"13.13", "13.4", "10.18", "10.16", "10.15", "10.13", "10.6", "9.6", "9.5"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs cleaning up, we discussed this already here remove the 10 and 9 versions because they are depecrated , any version of 13, below or equal to 13.10 needs to be removed and add the versions of 13 that are available i.e. 13.11 , 13.12, 13.13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for verification create postres cr for aws and confirm that CRO provisions a 13.13 version of postgres.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for comments!

  • defaultSupportedEngineVersions - updated.
  • Checked that CRO provisions a 13.13 version of postgres:
$ PROVIDER=aws make cluster/seed/postgres
...
$ oc describe postgres.integreatly.org/example-postgres
....
Status:
  Message:  reconcileRDSInstance() in progress, current aws rds resource status is modifying
  Phase:    in progress
  Secret Ref:
    Name:   
  Version:  13.13
Events:     <none>

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16682b7) 72.52% compared to head (8dd3361) 72.52%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          54       54           
  Lines        7060     7060           
=======================================
  Hits         5120     5120           
  Misses       1545     1545           
  Partials      395      395           
Files Coverage Δ
pkg/providers/aws/provider_postgres.go 66.24% <ø> (ø)

@austincunningham
Copy link
Member

/retest

@austincunningham
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: austincunningham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit af350d2 into integr8ly:master Jan 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants