Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGDAPI-6133 Bump default Redis to 6 #695

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

carlkyrillos
Copy link
Contributor

Overview

JIRA: MGDAPI-6133

Verification

  1. Provision non-CCS cluster
  2. Build CRO images from this PR
  3. Install RHOAM from CatalogSource but before creating the RHMI CR, patch the managed-api-service CSV with the custom CRO image
  4. Verify that the RHOAM installation completes

Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from carlkyrillos. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #695 (5ee0ea2) into master (0b51d40) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          54       54           
  Lines        7060     7060           
=======================================
  Hits         5120     5120           
  Misses       1545     1545           
  Partials      395      395           
Files Coverage Δ
pkg/providers/openshift/provider_redis.go 80.39% <100.00%> (ø)

@briangallagher briangallagher merged commit 9595b9f into integr8ly:master Nov 29, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants