Merge pull request #574 from cecobask/MGDAPI-4629

MGDAPI-4629 remove gosec rule g101
integr8ly · Nov 29, 2022 · 2549778 · 2549778
2 parents 7de570c + 25131f0
commit 2549778
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -258,4 +258,4 @@ setup/sts:
 
 .PHONY: gosec
 gosec:
-	gosec -exclude=G101,G402,G404 -exclude-dir=hack/redis ./...
+	gosec -exclude=G402,G404 -exclude-dir=hack/redis ./...
diff --git a/pkg/providers/aws/credentials_sts_manager.go b/pkg/providers/aws/credentials_sts_manager.go
@@ -14,7 +14,7 @@ import (
 const (
 	defaultSTSCredentialSecretName = "sts-credentials"
 	defaultRoleARNKeyName          = "role_arn"
-	defaultTokenPath               = "/var/run/secrets/openshift/serviceaccount/token"
+	defaultTokenPath               = "/var/run/secrets/openshift/serviceaccount/token" // #nosec G101 -- false positive (ref: https://securego.io/docs/rules/g101.html)
 )
 
 var _ CredentialManager = (*STSCredentialManager)(nil)

diff --git a/pkg/providers/aws/provider_blobstorage.go b/pkg/providers/aws/provider_blobstorage.go
@@ -40,7 +40,7 @@ const (
 	defaultAwsBucketNameLength            = 40
 	DetailsBlobStorageBucketName          = "bucketName"
 	DetailsBlobStorageBucketRegion        = "bucketRegion"
-	DetailsBlobStorageCredentialKeyID     = "credentialKeyID"
+	DetailsBlobStorageCredentialKeyID     = "credentialKeyID" // #nosec G101 -- false positive (ref: https://securego.io/docs/rules/g101.html)
 	DetailsBlobStorageCredentialSecretKey = "credentialSecretKey"
 	defaultForceBucketDeletion            = false
 

diff --git a/pkg/providers/aws/provider_postgres.go b/pkg/providers/aws/provider_postgres.go
@@ -54,7 +54,7 @@ const (
 	defaultAwsPostgresUser               = "postgres"
 	defaultAwsPubliclyAccessible         = false
 	defaultAwsSkipFinalSnapshot          = false
-	defaultCredSecSuffix                 = "-aws-rds-credentials"
+	defaultCredSecSuffix                 = "-aws-rds-credentials" // #nosec G101 -- false positive (ref: https://securego.io/docs/rules/g101.html)
 	defaultPostgresPasswordKey           = "password"
 	defaultPostgresUserKey               = "user"
 	defaultStorageEncrypted              = true

diff --git a/pkg/providers/openshift/provider_postgres.go b/pkg/providers/openshift/provider_postgres.go
@@ -41,7 +41,7 @@ var (
 	defaultPostgresUserKey     = "user"
 	defaultPostgresPasswordKey = "password"
 	defaultPostgresDatabaseKey = "database"
-	defaultCredentialsSec      = "postgres-credentials"
+	defaultCredentialsSec      = "postgres-credentials" // #nosec G101 -- false positive (ref: https://securego.io/docs/rules/g101.html)
 )
 
 // PostgresStrat to be used to unmarshal strat map

diff --git a/pkg/resources/custom_metrics.go b/pkg/resources/custom_metrics.go
@@ -29,7 +29,7 @@ const (
 	DefaultRedisSnapshotNotAvailable          = "cro_redis_snapshot_not_found"
 	DefaultRedisSnapshotStatusMetricName      = "cro_redis_snapshot_status_phase"
 	DefaultRedisStatusMetricName              = "cro_redis_status_phase"
-	DefaultSTSCredentialsSecretMetricName     = "cro_sts_credentials_secret"
+	DefaultSTSCredentialsSecretMetricName     = "cro_sts_credentials_secret" // #nosec G101 -- false positive (ref: https://securego.io/docs/rules/g101.html)
 	DefaultVpcActionMetricName                = "cro_vpc_action"
 )