This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CO-450] Fix random-improve fallback (develop) #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple successive outputs
…n random-improve fails
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 11, 2019
4159: [CO-450] Fix random-improve fallback (develop) r=KtorZ a=KtorZ
## Description
<!--- A brief description of this PR and the problem is trying to solve -->
- A fix for the error messages which used to report a wrong balance upon failure.
- Implementation of the solution A
- Three automated regression tests:
- Verify that the fallback fix indeed works. Test was introduced prior to the fix to illustrate how the random-improve algorithm would greedily consume all available inputs leaving nothing for remaining outputs. Fixed with the fallback introduced in A.
- Verify that the API now returns a correct balance when indeed, the selection fails to select additional UTxO in a multi-outputs transaction
- An extra regression tests related to [CO-449](https://iohk.myjetbrains.com/youtrack/issue/CO-449), proving that the guard added for CO-449 is indeed successful at catching oversized transactions
## Linked issue
<!--- Put here the relevant issue from YouTrack -->
See [CO-450](https://iohk.myjetbrains.com/youtrack/issue/CO-450)
Co-authored-by: KtorZ <matthias.benkort@gmail.com>
Build succeeded |
iohk-bors
bot
deleted the
KtorZ/CO-450/fix-random-improve-fallback-develop
branch
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
See CO-450
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.