Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-1046] Use new internal/import-wallet endpoint #3594

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

disassembler
Copy link
Contributor

Description

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@disassembler disassembler force-pushed the devops-1046-internal-import-wallet-demo branch from 5f2b5d7 to 2b0666b Compare September 13, 2018 16:00
@disassembler disassembler requested review from iohk-devops and a team and removed request for iohk-devops September 14, 2018 02:40
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work. I ran the demo-cluster script and checked /api/v1/wallets endpoint and could see those imported wallets (with the new name).

@rvl rvl merged commit c7b1ce1 into develop Sep 14, 2018
@rvl rvl deleted the devops-1046-internal-import-wallet-demo branch September 14, 2018 03:47
KtorZ pushed a commit that referenced this pull request Nov 9, 2018
…port-wallet-demo

[DEVOPS-1046] Use new internal/import-wallet endpoint
KtorZ pushed a commit to input-output-hk/cardano-wallet-legacy that referenced this pull request Nov 9, 2018
…hk/devops-1046-internal-import-wallet-demo

[DEVOPS-1046] Use new internal/import-wallet endpoint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants