This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-427] Make NtpCheck non-blocking unless explicitly forced #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing the new data-layer 'node-info' handler, we've made the choice to have the underlying check for NtpStatus blocking / synchronous. This choices is usually fine as the check normally takes around ~100ms. However, when running on CI, we do not connect to the Internet and therefore, will always timeout for those check. This could be the cause for the integration tests bootstrap not syncing properly (not telling us about it).
akegalj
approved these changes
Sep 13, 2018
|
|
||
| getNtpOffset :: MonadIO m => (NtpStatus -> STM (Maybe NtpOffset)) -> m (Maybe NtpOffset) | ||
| getNtpOffset lookupNtpOffset = | ||
| atomically $ (readTVar tvar >>= lookupNtpOffset) |
There was a problem hiding this comment.
minor: $ (...) - either function application of parens are unecessary
There was a problem hiding this comment.
True this. The parens are useful here but not the $ application.
| -> m V1.TimeInfo | ||
| defaultGetNtpDrift tvar ntpCheckBehavior = liftIO $ mkTimeInfo <$> | ||
| if (ntpCheckBehavior == V1.ForceNtpCheck) then | ||
| forceNtpCheck >> getNtpOffset blockingLookupNtpOffset |
There was a problem hiding this comment.
@KtorZ wouldn't be better to have atomically at the boundary but keep forceNtpCheck and getNtpOffset running in STM, so that they compose better?
There was a problem hiding this comment.
Well, we can't 🙃 ... We need to force the check first, commit the transaction, and then, get the offset :)
On the other side, there's also a process watching this TVar which is triggered by the forceNtpCheck. Then, we just wait for that process to update the var to something that isn't "Pending"
KtorZ
added a commit
that referenced
this pull request
Nov 9, 2018
…ing-ntp-check [CBR-427] Make NtpCheck non-blocking unless explicitly forced
KtorZ
added a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/KtorZ/CBR-427/non-blocking-ntp-check [CBR-427] Make NtpCheck non-blocking unless explicitly forced
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When implementing the new data-layer 'node-info' handler, we've made the
choice to have the underlying check for NtpStatus blocking /
synchronous. This choices is usually fine as the check normally takes
around ~100ms. However, when running on CI, we do not connect to the
Internet and therefore, will always timeout for those check. This could
be the cause for the integration tests bootstrap not syncing properly
(not telling us about it).
Linked issue
[CBR-427]
Type of change
Developer checklist
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.Testing checklist
[ ] I have added tests to cover my changes.QA Steps
Screenshots (if available)