fix/rabbitmq-wrong-interface #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccicci
changed the title
mkazlauskas
requested changes
Jun 16, 2022
iccicci
force-pushed
the
fix/ADP-1874-tx-submit-worker-error-handling
branch
from
4a9de5b
to
d31d060
Compare
mkazlauskas
requested changes
Jun 17, 2022
iccicci
force-pushed
the
fix/ADP-1874-tx-submit-worker-error-handling
branch
from
fa40887
to
8b785c0
Compare
mkazlauskas
requested changes
Jun 21, 2022
iccicci
force-pushed
the
fix/ADP-1874-tx-submit-worker-error-handling
branch
2 times, most recently
from
897d266
to
c9bde11
Compare
rhyslbw
requested changes
Jun 24, 2022
There was a problem hiding this comment.
Fantastic work @iccicci 🎉
Please autosquash and request final review from @ssong-iohk
rhyslbw
force-pushed
the
fix/ADP-1874-tx-submit-worker-error-handling
branch
from
febf84e
to
ca16019
Compare
rhyslbw
force-pushed
the
fix/ADP-1874-tx-submit-worker-error-handling
branch
from
ca16019
to
a880367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The package
@cardano-sdk/rabbitmqdoesn't respect all thecardano-js-sdkstandards and has a severely wrong error handling, in details:Promisereturned byTxSubmitWorker.startshould resolve at the end of the init stage rather than when theTxSubmitWorkerexits: ADP-1886TxSubmitWorkershould retry only those errors which can be retried rather than all the errors: ADP-1874TxSubmitWorkershould let know theRabbitMqTxSubmitProviderwhen a transaction is in mempool (or in case of error, propagate it) in order to let thePromisereturned byRabbitMqTxSubmitProvider.submitTxto resolve when the transaction is in mempool or reject with the original error: ADP-1823Proposed Solution
The package
@cardano-sdk/rabbitmqhave been completely refactored.Important Changes Introduced
@cardano-sdk/rabbitmqinterface was applied to@cardano-sdk/cardano-services.@cardano-sdk/ogmioswas enriched to respond with an error which can be retried.@cardano-sdk/cardano-servicesload test are meaningful.